Skip to content

[otlp] Fix .NET Framework gRPC Export Client Default Success Response Status#6099

Merged
CodeBlanch merged 2 commits intoopen-telemetry:mainfrom
rajkumar-rangaraj:rajrang/fixNetFrameworkSuccessResponse
Jan 24, 2025
Merged

[otlp] Fix .NET Framework gRPC Export Client Default Success Response Status#6099
CodeBlanch merged 2 commits intoopen-telemetry:mainfrom
rajkumar-rangaraj:rajrang/fixNetFrameworkSuccessResponse

Conversation

@rajkumar-rangaraj
Copy link
Member

@rajkumar-rangaraj rajkumar-rangaraj commented Jan 24, 2025 •
edited
Loading

Fixes #6083 (comment)
Design discussion issue #

Changes

Please provide a brief description of the changes here.

  • Modified the incorrect status value set in ExportClientGrpcResponse.
  • Existing bug does not impact the telemetry data to be exported. This could be part of next release.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@rajkumar-rangaraj
Fixed a bug in .NET Framework gRPC export client where the default su…
bc950f9 
…ccess export response was incorrectly marked
@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team as a code owner January 24, 2025 00:26
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Jan 24, 2025
CodeBlanch
CodeBlanch approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 2828321 into open-telemetry:main Jan 24, 2025
35 checks passed
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (db828ce) to head (8ae86e4).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6099   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files         257      257           
  Lines       11650    11650           
=======================================
  Hits        10065    10065           
  Misses       1585     1585

This was referenced Sep 8, 2025
Closed
Merged
Merged
Closed
Closed
This was referenced Sep 29, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 6, 2025
Closed
Merged
Open
Open
Closed
Closed
Closed
Open
This was referenced Jan 19, 2026
Closed
Closed
Closed
Open
Closed
Open
Open
Closed
Merged
Open
Open
This was referenced Jan 26, 2026
Closed
Closed
Closed
Open
Open
Closed
Closed
This was referenced Feb 3, 2026
Closed
Closed
Open
Open
This was referenced Feb 10, 2026
Open
Closed
This was referenced Feb 23, 2026
Open
Merged
Merged
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CodeBlanch CodeBlanch CodeBlanch approved these changes

Assignees

No one assigned

Labels

pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rajkumar-rangaraj @CodeBlanch